feat(hono-base): tweaks fetch signature for better compatibility wi…

…th `deno serve` (#2661)
honojs · May 11, 2024 · 6db1cc6 · 6db1cc6
1 parent e460f02
commit 6db1cc6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/deno_dist/hono-base.ts b/deno_dist/hono-base.ts
@@ -371,8 +371,12 @@ class Hono<
    * `.fetch()` will be entry point of your app.
    * @see https://hono.dev/api/hono#fetch
    */
-  fetch = (request: Request, Env?: E['Bindings'] | {}, executionCtx?: ExecutionContext) => {
-    return this.dispatch(request, executionCtx, Env, request.method)
+  fetch: (
+    request: Request,
+    Env?: E['Bindings'] | {},
+    executionCtx?: ExecutionContext
+  ) => Response | Promise<Response> = (request, ...rest) => {
+    return this.dispatch(request, rest[1], rest[0], request.method)
   }
 
   /**

diff --git a/src/hono-base.ts b/src/hono-base.ts
@@ -371,8 +371,12 @@ class Hono<
    * `.fetch()` will be entry point of your app.
    * @see https://hono.dev/api/hono#fetch
    */
-  fetch = (request: Request, Env?: E['Bindings'] | {}, executionCtx?: ExecutionContext) => {
-    return this.dispatch(request, executionCtx, Env, request.method)
+  fetch: (
+    request: Request,
+    Env?: E['Bindings'] | {},
+    executionCtx?: ExecutionContext
+  ) => Response | Promise<Response> = (request, ...rest) => {
+    return this.dispatch(request, rest[1], rest[0], request.method)
   }
 
   /**