Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deno): change path including deno_dist #2788

Merged
merged 1 commit into from
May 25, 2024
Merged

chore(deno): change path including deno_dist #2788

merged 1 commit into from
May 25, 2024

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented May 25, 2024 •
edited
Loading

Fix path including deno_dist.
--unstable-sloppy-imports flag is now required on benchmark due to jsr aliases.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun denoify to generate files for Deno
  • bun run format:fix && bun run lint:fix to format the code

@yusukebe
Copy link
Member

@ryuapp

Thanks!

@yusukebe yusukebe merged commit 82cfd46 into honojs:next May 25, 2024
10 checks passed
@ryuapp ryuapp deleted the remove-deno_dist-rest branch May 26, 2024 01:52
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryuapp @yusukebe