-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HasIslands
supports nested components
#102
Conversation
* Remove `precinct.d.ts` to build successfully. * Don't use `magic-string` to reduce dependencies. * Fix `precinct` opions.
HasIslands
supports nested components
Hey @bruceharrison1984 ! I have made changes to 7099fba. Anyway, this PR must be completed. What do you think about my change? |
@yusukebe Is this also working with alias imports? That was one issue with what currently exists. I think that by using As an opinion, while I realize removing |
Yeah. I added tests for alias importing. 8612936. It seems to be working! Can you see this again? |
After merge this, we have to resolve this matter: #105 |
@yusukebe LGTM Was the only piece I was missing adding the alias to the |
@bruceharrison1984 Thanks! Land it! |
This makes a change to the Islands scanning code so that it walks the dependency tree. The current implementation only allows for islands to work if they are directly within the Route. This change allows Islands to be anywhere in the hierarchy.
This PR is more of a working session to try and get this sorted out, because the current implementation is extremely limited and negatively impacts the way users can structure their components. The other alternative is to just always ship the client libraries, but that seems to run counter to why Islands was implemented in the first place.
Current shortfalls:
tsx
filesThis works was based on conversations from #46