-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable to put "island" not only in islands
directory
#140
Conversation
Hi @usualoma @bruceharrison1984 Could you review this? |
LGTM, however why constraint it to Either way, I think this is a good incremental improvement to the Islands concept. |
Thanks @bruceharrison1984 !
Good question! This is related to the discussion in #45. At first, I also thought I could just put the island file in This is one example: .
└── app
├── islands
│ └── online-status.tsx
└── routes
├── chats
│ ├── [id]
│ │ ├── _chat.island.tsx
│ │ └── index.tsx
│ └── index.tsx
└── index.tsx I think it would be better to put common islands in |
@usualoma Any thoughts? |
@yusukebe Thanks. LGTM! |
Thanks! Merge now. |
I think @bruceharrison1984 was asking why it needs to be in For example My project is ordered by features so it would be nice to do
I decided to patch this in, I made an issue that includes the patch if you are interested. |
Related to #45
With this PR, you can put an island component in a directory under
/app/routes
, not only the/app/islands
directory. You should name it with a_
prefix, like_counter.island.tsx
.It was inefficient to put Islands in
/app/islands
, which are used only in a certain directory. However, this PR makes it easier to understand the structure by placing Islands in the same directory as the files that use them.