-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Script
and HasIsland
available at multiple runtimes with AsyncLocalStorage
#168
Merged
yusukebe
merged 4 commits into
honojs:main
from
usualoma:feat/has-island-script-multi-runtime-async-local-storage
May 10, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
30b0190
feat: Use AsyncLocalStorage to share context in same request
usualoma fa52bab
feat: replace reactApiImportSource also in server components
usualoma 4e41724
feat: use `any` instead of `FC` for components for multi-runtime comp…
usualoma 4d52781
test: add test for server/components
usualoma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,11 @@ | ||
import type { FC } from 'hono/jsx' | ||
import { useRequestContext } from 'hono/jsx-renderer' | ||
import { IMPORTING_ISLANDS_ID } from '../../constants.js' | ||
import { contextStorage } from '../context-storage.js' | ||
|
||
export const HasIslands: FC = ({ children }) => { | ||
const c = useRequestContext() | ||
return <>{c.get(IMPORTING_ISLANDS_ID) ? children : <></>}</> | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
export const HasIslands = ({ children }: { children: any }): any => { | ||
const c = contextStorage.getStore() | ||
if (!c) { | ||
throw new Error('No context found') | ||
} | ||
return <>{c.get(IMPORTING_ISLANDS_ID) && children}</> | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { AsyncLocalStorage } from 'node:async_hooks' | ||
import type { Context } from 'hono' | ||
export const contextStorage = new AsyncLocalStorage<Context>() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! Only a few code can adapt
AsyncLocalStorage
to a Hono app.