fix(zod-openapi): remove the type error for the hook (#607)

* fix(zod-openapi): remove the type error for the hook * add changeset
honojs · Jul 1, 2024 · 375c98b · 375c98b
1 parent f058604
commit 375c98b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/.changeset/honest-shrimps-change.md b/.changeset/honest-shrimps-change.md
@@ -0,0 +1,5 @@
+---
+'@hono/zod-openapi': patch
+---
+
+fix: remove the type error for the hook
diff --git a/packages/zod-openapi/src/index.ts b/packages/zod-openapi/src/index.ts
@@ -322,7 +322,17 @@ export class OpenAPIHono<
           I,
           E,
           P,
-          RouteConfigToTypedResponse<R> | Response | Promise<Response> | void | Promise<void>
+          R extends {
+            responses: {
+              [statusCode: number]: {
+                content: {
+                  [mediaType: string]: ZodMediaTypeObject
+                }
+              }
+            }
+          }
+            ? MaybePromise<RouteConfigToTypedResponse<R>> | undefined
+            : MaybePromise<RouteConfigToTypedResponse<R>> | MaybePromise<Response> | undefined
         >
       | undefined = this.defaultHook
   ): OpenAPIHono<

diff --git a/packages/zod-openapi/test/index.test.ts b/packages/zod-openapi/test/index.test.ts
@@ -1019,14 +1019,13 @@ describe('With hc', () => {
       },
       (result, c) => {
         if (!result.success) {
-          const res = c.json(
+          return c.json(
             {
               ok: false,
               source: 'routeHook' as const,
             },
             400
           )
-          return res
         }
       }
     )