fix(sentry): fixed sentry options types (#130)

* fix(sentry): fixed sentry options types * changeset
honojs · Aug 23, 2023 · de2e95a · de2e95a
1 parent 9f901b9
commit de2e95a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 25 deletions.
diff --git a/.changeset/strong-hotels-kiss.md b/.changeset/strong-hotels-kiss.md
@@ -0,0 +1,5 @@
+---
+'@hono/sentry': patch
+---
+
+fixed sentry options types
diff --git a/packages/sentry/deno_dist/index.ts b/packages/sentry/deno_dist/index.ts
@@ -1,5 +1,6 @@
 import type { Context, MiddlewareHandler } from 'https://deno.land/x/hono/mod.ts'
 import Toucan from 'https://cdn.skypack.dev/toucan-js@2.7.0'
+import type { Options as ToucanOptions } from 'https://cdn.skypack.dev/toucan-js@2.7.0'
 
 declare module 'https://deno.land/x/hono/mod.ts' {
   interface ContextVariableMap {
@@ -11,23 +12,13 @@ class MockContext implements ExecutionContext {
   passThroughOnException(): void {
     throw new Error('Method not implemented.')
   }
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   async waitUntil(promise: Promise<any>): Promise<void> {
     await promise
   }
 }
 
-export type Options = {
-  dsn?: string
-  allowedCookies?: string[] | RegExp
-  allowedHeaders?: string[] | RegExp
-  allowedSearchParams?: string[] | RegExp
-  attachStacktrace?: boolean
-  debug?: boolean
-  environment?: string
-  maxBreadcrumbs?: number
-  pkg?: Record<string, any>
-  release?: string
-}
+export type Options = Omit<ToucanOptions, 'request' | 'context'>
 
 export const sentry = (
   options?: Options,

diff --git a/packages/sentry/src/index.ts b/packages/sentry/src/index.ts
@@ -1,5 +1,6 @@
 import type { Context, MiddlewareHandler } from 'hono'
 import Toucan from 'toucan-js'
+import type { Options as ToucanOptions } from 'toucan-js'
 
 declare module 'hono' {
   interface ContextVariableMap {
@@ -11,23 +12,13 @@ class MockContext implements ExecutionContext {
   passThroughOnException(): void {
     throw new Error('Method not implemented.')
   }
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   async waitUntil(promise: Promise<any>): Promise<void> {
     await promise
   }
 }
 
-export type Options = {
-  dsn?: string
-  allowedCookies?: string[] | RegExp
-  allowedHeaders?: string[] | RegExp
-  allowedSearchParams?: string[] | RegExp
-  attachStacktrace?: boolean
-  debug?: boolean
-  environment?: string
-  maxBreadcrumbs?: number
-  pkg?: Record<string, any>
-  release?: string
-}
+export type Options = Omit<ToucanOptions, 'request' | 'context'>
 
 export const sentry = (
   options?: Options,

diff --git a/packages/sentry/src/replacer.ts b/packages/sentry/src/replacer.ts
@@ -17,7 +17,7 @@ makeThisModuleAnExecutableReplacer(async ({ parsedImportExportStatement, version
       ...parsedImportExportStatement,
       parsedArgument: {
         type: 'URL',
-        url: `https://deno.land/x/hono/mod.ts`,
+        url: 'https://deno.land/x/hono/mod.ts',
       },
     })
   }

diff --git a/packages/sentry/test/index.test.ts b/packages/sentry/test/index.test.ts
@@ -6,6 +6,7 @@ class Context implements ExecutionContext {
   passThroughOnException(): void {
     throw new Error('Method not implemented.')
   }
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   async waitUntil(promise: Promise<any>): Promise<void> {
     await promise
   }