Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getRoutingPath to the return value of createRoute. #161

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

naporin0624
Copy link
Contributor

closed: #159

  • Add getRoutingPath to the return value of createRoute
  • Create getRoutingPath type from createRoute so that it can be referenced from c.req.param.
  • Add tests for return value and type of getRoutingPath

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

🦋 Changeset detected

Latest commit: f03f04f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/zod-openapi Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

Hi @naporin0624 !

It is great that you wrote a test and make it supports the path param types. Looks good! I'll merge it now.

@yusukebe yusukebe merged commit 05b8e9a into honojs:main Sep 18, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
@naporin0624 naporin0624 deleted the feat/issue-159 branch September 19, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we accept middleware in @hono/zod-openapi's openapi method?
2 participants