Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'middleware' property for route #435

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

RomanNabukhotnyi
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Mar 28, 2024

🦋 Changeset detected

Latest commit: d149567

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/zod-openapi Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@flipvh
Copy link

flipvh commented Apr 10, 2024

@yusukebe you had a chance to look at this approach to support route-specific middleware in a more DRY manner when using zod-openapi? It is related to #417 Thnks and we are patiently awaiting your consideration!

@yusukebe
Copy link
Member

@RomanNabukhotnyi @flipvh

Sorry for the delayed response. I've considered it. This is good! I've left one comment. Check it.

@RomanNabukhotnyi RomanNabukhotnyi changed the title feat: Add 'middlewares' property for route feat: Add 'middleware' property for route Apr 11, 2024
@RomanNabukhotnyi
Copy link
Contributor Author

@yusukebe Hey! Your suggestions have been applied

@yusukebe
Copy link
Member

@RomanNabukhotnyi

Thank you very much! One thing. If you can, can you update the README to describe this option?

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@RomanNabukhotnyi

Great! I'll merge this now. Thank you so much!

@yusukebe
Copy link
Member

yusukebe commented Apr 11, 2024

@RomanNabukhotnyi

Oops. Could you check the comment?

@yusukebe
Copy link
Member

Okay! Let's go!

@yusukebe yusukebe merged commit 4660092 into honojs:main Apr 11, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
@flipvh
Copy link

flipvh commented Apr 11, 2024

Cheers Yusuke! Thanks! 🍻 👍

@RomanNabukhotnyi RomanNabukhotnyi deleted the middlewares branch April 11, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants