Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zod-openapi: make getRoutingPath non-enumerable #445

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

fumieval
Copy link
Contributor

This prevents potential serialisation errors (e.g. yaml's stringify) of the return value of getOpenAPIDocument.

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 95670ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/zod-openapi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This prevents potential serialisation errors (e.g. yaml's `stringify`) of the return value of getOpenAPIDocument
@fumieval fumieval force-pushed the non-enumerable-getRoutingPath branch from e63a9bd to 573b611 Compare April 10, 2024 12:55
@yusukebe
Copy link
Member

@fumieval

Nice! Merge this now. Thanks for your contribution.

@yusukebe
Copy link
Member

@fumieval

One thing. Can you run the yarn changeset at the top of the project? This will be a patch.

@fumieval fumieval force-pushed the non-enumerable-getRoutingPath branch from 645c497 to 95670ba Compare April 11, 2024 05:16
@fumieval
Copy link
Contributor Author

@yusukebe Sure, I added a changeset here: 95670ba

@yusukebe
Copy link
Member

Thanks!

@yusukebe yusukebe merged commit 110e272 into honojs:main Apr 11, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants