Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-renderer): Change react-renderer props to interface #668

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

alexturpin
Copy link
Contributor

Copy link

changeset-bot bot commented Jul 28, 2024

🦋 Changeset detected

Latest commit: 349fcec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/react-renderer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe yusukebe changed the title Change react-renderer props to interface fix(react-renderer): Change react-renderer props to interface Jul 28, 2024
@yusukebe
Copy link
Member

Hi @alexturpin

Nice! One thing. Can you run yarn changeset on the top of the project to create a changeset and push it?

@alexturpin
Copy link
Contributor Author

@yusukebe done, I think that looks right?

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@alexturpin Yes, great! I'll merge now. Thanks!

@yusukebe yusukebe merged commit 9c58014 into honojs:main Jul 31, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't merge type of props for React renderer
2 participants