Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@hono/oauth-providers): Added missing URL parameters prompt, login_hint, and access_type in the Google OAuth provider. #697

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

taishinaritomi
Copy link
Contributor

@taishinaritomi taishinaritomi commented Aug 18, 2024

Added missing URL parameters prompt, login_hint, and access_type in the Google OAuth provider.

https://developers.google.com/identity/protocols/oauth2/web-server#httprest

Copy link

changeset-bot bot commented Aug 18, 2024

🦋 Changeset detected

Latest commit: bc128cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/oauth-providers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taishinaritomi taishinaritomi changed the title fix(@hono/oauth-providers): google provider attach custom parameters fix(@hono/oauth-providers): Added missing URL parameters prompt, login_hint, and access_type in the Google OAuth provider. Aug 18, 2024
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@taishinaritomi

Thanks! Merging now.

@yusukebe yusukebe merged commit c3b67a6 into honojs:main Aug 19, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants