Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat [#127] : support compression gzip, deflate #128

Closed
wants to merge 1 commit into from

Conversation

ariskemper
Copy link
Contributor

@ariskemper ariskemper commented Jan 24, 2024

it fix issue #127 with using compress middleware on node.js honojs/hono#2061

@@ -0,0 +1,16 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file necessary?

@yusukebe
Copy link
Member

Hi @ariskemper !

Thanks so much. Looks great to me!

@usualoma Could you review this?

@usualoma
Copy link
Member

Hi @ariskemper
Thanks for creating the PR!

But I think the problem with honojs/hono#2061 is not with "node-server" but with "core". It should be fixed once the following PR is merged.
honojs/hono#2080

cc: @yusukebe

@ariskemper ariskemper closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants