[hotfix.readin.stringlength] Hotfix read-in long strings from parameter-file #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopperp
approved these changes
Jan 16, 2024
…aracter array (instead of fixed length) to avoid truncation of long input lines use case: periodic box where corner coordinates are irrational numbers, e.g. as obtained from trigonometric relations -> coordinates have to be given with sufficient decimals for opposite sides to be identified as conforming
kopperp
force-pushed
the
hotfix.readin.stringlength
branch
from
758719d
to
2f16f57
Compare
scopplestone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when reading parameter-file, cast varying_string to deferred-shape CHAR array (instead of fixed-length CHAR array) to avoid truncation of long input lines
use case: periodic box where corner coordinates are irrational numbers, e.g. as obtained from trigonometric relations -> coordinates have to be given with sufficient decimals for opposite sides to be identified as conforming