Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: STORE for iCloud and other strict IMAP servers #31

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

ralflang
Copy link
Member

This is Anna's PR #30 but against FRAMEWORK_6_0

Apple's iCloud IMAP server (and possibly others, although I haven't tested it) want brackets around any FLAG command params as shown in the examples of RFC3501 If the brackets aren't added, the command fails with BAD Parse Error To fix this, wrap the params of a STORE command in a Horde_Imap_Client_Data_Format_List Otherwise, the \Delete FLAG, \Seen FLAG and possibly all other PERMFLAGs aren't added, even if the STORE command doesn't return a BAD response.

Apple's iCloud IMAP server (and possibly others, although I haven't tested it) want brackets around any
FLAG command params as shown in the examples of [RFC3501](https://datatracker.ietf.org/doc/html/rfc3501#section-6.4.6])
If the brackets aren't added, the command fails with BAD Parse Error
To fix this, wrap the params of a STORE command in a Horde_Imap_Client_Data_Format_List
Otherwise, the \Delete FLAG, \Seen FLAG and possibly all other PERMFLAGs aren't added, even if the
STORE command doesn't return a BAD response.

Signed-off-by: Anna Larch <anna@nextcloud.com>
Copy link

what-the-diff bot commented Mar 28, 2024

PR Summary

  • Improved code usage in Socket.php
    The respective changes in this file aim to enhance how the FLAGS value is set in the $cmds array. We switched from a direct use of replace and add/remove values to a more efficient usage of Horde_Imap_Client_Data_Format_List class. This adjustment correlates with better consistency in data format management and can potentially lead to fewer bugs in the future.

@ralflang ralflang merged commit 341f6d0 into FRAMEWORK_6_0 Mar 28, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants