Update internal links in Dropdowns to allow clicking on the entire span #4782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
d-rita
approved these changes
Jul 6, 2021
d-rita
requested review from
ramyaragupathy
and removed request for
dakotabenjamin
|
Thank you for this fix @zlavergne. Rebasing this and prepping it for merge. |
d-rita
force-pushed
the
fix/improve-internal-link-dropdowns
branch
from
cefee23 to
ddeb2c1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates any internal link within a Dropdown component to use
@react/router'snavigateinstead of aLink. Instead of having to click on the text of the link, a user can just click the "box" that it lives inCurrent behavior:
(must click the text)
New behavior:
(can click the surrounding area)
Closes #4781