Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve default comment to get correct project stats #4805

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Retrieve default comment to get correct project stats #4805

merged 3 commits into from
Jul 23, 2021

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Jul 14, 2021

Fixes #4804

@d-rita d-rita requested a review from ramyaragupathy July 14, 2021 14:32
@ramyaragupathy
Copy link
Member

Tested the functionality - it works as expected and retrieves the stats based on the default comment.
Changes suggested:

  • Accessing the default changeset comment in the frontend through an env variable
  • Adding an information in the statistics page that the numbers are retrieved based on the default changeset comment. If not users might flag this as an issue. So it is important we highlight this detail.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@d-rita d-rita requested a review from ramyaragupathy July 20, 2021 15:22
@d-rita
Copy link
Contributor Author

d-rita commented Jul 20, 2021

@ramyaragupathy I have made the changes:

  • Using the default changeset comment from the environment variables to check and retrieve the project stats.
  • And, adding a tooltip on the Edit Stats title indicating how these stats are got.

@ramyaragupathy
Copy link
Member

Thanks @d-rita - this looks good!

@ramyaragupathy ramyaragupathy merged commit 675c084 into develop Jul 23, 2021
@eternaltyro eternaltyro deleted the fix/retrieve-correct-edit-stats branch March 29, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramyaragupathy ramyaragupathy Awaiting requested review from ramyaragupathy

Assignees
No one assigned
Labels
scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix functionality to retrieve project stats
2 participants
@d-rita @ramyaragupathy