Frontend tests now has parallel workers & removed cluttered warnings #6414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dakotabenjamin
approved these changes
May 7, 2024
There was a problem hiding this comment.
Technically this is a good update, but are we sure we want to mute the warnings? @ramyaragupathy let me know your thoughts here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Frontend build despite using a Large resource class (4 core, 8GB) takes 6-7 Minutes. We can use parallel workers with
-wflag to get most out of available cpu cores.Also cluttered warnings has been removed with
--silent. This reduced CircleCI console logs from5000lines to900ish lines, making it easier to conceive.Screenshots
Before
After
Before
After
Alternative Approaches Considered
For 4 cores, with some testing i found out that
-w 3worked the best, setting-w 4or higher increased the test time also in cases freezed the VM instance.With more CPU compute this can be improved, Testing on
X-largeresource class had this time reduced to a minute.