-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastapi refactor #6557
Open
prabinoid
wants to merge
177
commits into
develop
Choose a base branch
from
fastapi-refactor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fastapi refactor #6557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
- Build multi-stage container images on specific targets - in this case 'prod' - Better naming for jobs Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
- Fix outputs format - Experiment with metadata parsing in different ways - Add labels back to container metadata Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
Signed-off-by: eternaltyro <230743+eternaltyro@users.noreply.github.com>
JSONResponse handling and cleanups
fix project filters
Fix project responses and filters
fix project info dto
fix project teams patch
β¦dled and queries bbox geojson serialized
β¦managers assignment fixed and message module fixes
β¦nd favourites fixes
β¦organisation manager fixed
prabinoid
force-pushed
the
fastapi-refactor
branch
from
November 4, 2024 11:38
6b772b7
to
4d4efec
Compare
β¦ aware * fix: All Teams Pagination fixed * fix: Json response for task split small area error message * fix: Timestamps serialization in messages, comments, and notifications
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
scope: backend
scope: frontend
scope: infrastructure
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Related discussion: https://community.openstreetmap.org/t/migrating-tasking-manager-from-flask-to-fastapi-and-psycopg2-to-asyncpg/116543
Describe this PR
This PR includes the TM fastapi migration and covers the commits from the initial phases of the migration.
This PR is made only for the code review of the migration which is an ongoing process and hence the PR should NOT be merged currently.
Initially, the migration was done with sqlalchemy AsyncSession and orm but later we switched to raw sql query and encode databases to manage our async sessions and queries due to which parts of code needs cleaning and might be ambiguous too.