View Task Instructions without login #6592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue: |
royallsilwallz
force-pushed
the
feature/6302-view-task-instructions
branch
2 times, most recently
from
fd8e657
to
1276d76
Compare
- Add `tabname` param to `/projects/:id/` route - Change local tab state to route param tabname - Remove footer for instructions & contributions route
- Enable task api call only when logged in - Add `taskBordersOnly` props for directly zooming to tasks in `ProjectDetailMap` - Zoom to task border initially
- Reason: Due to change in Tab selection logic with url routes
royallsilwallz
force-pushed
the
feature/6302-view-task-instructions
branch
from
1276d76
to
00400e4
Compare
- Fix redirect issue from tasks page to instructions and vice versa - Preserve respective page route on reload
- Fix test case failure for redirect issue in task page
royallsilwallz
force-pushed
the
feature/6302-view-task-instructions
branch
from
00400e4
to
cb58a09
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issue
Describe this PR
This PR enables user to share the task instructions URL of a project without having to log in to Tasking Manager.
Key Changes
View Project Specific Instructionsto the bottom ofDescriptionsection/instructionsand/contributionsProject Detail Mapinstead ofTask MapforInstructionspage when not logged inScreenshots