Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved: app to upgrade ionic to 7.6.0(#244) #245

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Improved: app to upgrade ionic to 7.6.0(#244) #245

merged 4 commits into from
Jan 9, 2024

Conversation

ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented Jan 5, 2024 •
edited
Loading

closes #244

@ymaheshwari1
Improved: app to upgrade ionic to 7.5.8(hotwax#244)
4cdc99e
@ymaheshwari1
Improved: usage of ion-select as per the changes in ionic7(hotwax#244)
e0580b9
@ymaheshwari1
Improved: the ionic version to 7.6.0(hotwax#244)
b970f10
@ymaheshwari1
Improved: the label for select options in product identifier component(…
56a5db3 
…hotwax#244)

Changed Primary Product Identifier to Primary
Changed Secondary Product Identifier to Secondary
The changes are made as after upgrading ionic the labels are getting truncated and also the label are having redundant keyword as product identifier
@ymaheshwari1
Copy link
Contributor Author

ymaheshwari1 commented Jan 9, 2024 •
edited
Loading

  • Upgraded Ionic to 7.6.0
  • Updated the usage of some components as per the changes required
  • Changed the label for select options inside Product Identifier card, as after ionic upgrade the labels are getting truncated, and also the labels are having redundant keywords.
  • Used label property in ion-select as its recommended for plaintext labels.

@ymaheshwari1 ymaheshwari1 changed the title Improved: app to upgrade ionic to 7.5.8(#244) Improved: app to upgrade ionic to 7.6.0(#244) Jan 9, 2024
@ymaheshwari1 ymaheshwari1 merged commit 3e7e1da into hotwax:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate ionic to 7.6.0
1 participant
@ymaheshwari1