-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used luxon instead of moment #1vy5ryh #29
Conversation
@@ -120,9 +116,10 @@ export default defineComponent({ | |||
// Currently backend API returns some of the legacy timezones which are not found in moment list | |||
// Due to which if we set them we get an error | |||
// Filtered them out till it is fixed at backend | |||
this.timeZones = resp.data.filter((timeZone: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we have commented this out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the commented code and comments because we are not using moment anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we are checking if the server timezone belongs to moment as well. We should also handle it for luxon. Check if we are similar method in Luxon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handled it for luxon as well
src/App.vue
Outdated
text: this.$t("Dismiss"), | ||
role: 'cancel', | ||
cssClass: 'secondary' | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert all the unrelated indentation changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted indentation changes.
…tation changes(#1vy5ryh)
@@ -120,9 +116,10 @@ export default defineComponent({ | |||
// Currently backend API returns some of the legacy timezones which are not found in moment list | |||
// Due to which if we set them we get an error | |||
// Filtered them out till it is fixed at backend | |||
this.timeZones = resp.data.filter((timeZone: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we are checking if the server timezone belongs to moment as well. We should also handle it for luxon. Check if we are similar method in Luxon
src/views/TimezoneModal.vue
Outdated
} | ||
} | ||
], | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert unrelated indentation changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted unrelated indentation changes
No description provided.