Implemented: order schema and its related schema used in the order taking reference from the moqui order schema(#2f2h74x) #54
Conversation
ymaheshwari1
commented
Jun 10, 2022
•
ymaheshwari1
commented
- Removed some fields those are not needed in the order schema for app side
- Declared different files for each dependent schema: Enumeration, Status, Identification, Geo, Party, ContactMech, Uom, Order
…king reference from the moqui order schema(#2f2h74x)
…ired and updated some parameters enumeration entity as required(#2f2h74x)
src/types/Identification.ts
Outdated
| @@ -0,0 +1,11 @@ | |||
| import { Enumeration } from "./index"; | |||
|
|
|||
There was a problem hiding this comment.
Identifications can be for many different entities, Product, Party, Order etc.
Should we rename this to PartyIdentification ?
There was a problem hiding this comment.
Sir, Deleted this schema as renamed it to PartyIdentification schema and declared it in the Party.ts file instead of having a separate schema file.
src/types/Identification.ts
Outdated
| @@ -0,0 +1,11 @@ | |||
| import { Enumeration } from "./index"; | |||
|
|
|||
There was a problem hiding this comment.
Should we consider renaming to PartyIdentification?
We will have identifications for Products, Orders, Party etc.
There was a problem hiding this comment.
Yes Sir. We have the same pattern in Moqui as well
https://demo.moqui.org/qapps/tools/Entity/DataEdit/EntityList?filterRegexp=Identification&viewOption=all&submitButton=submitButton
src/types/Order.ts
Outdated
| currencyUom?: Uom, | ||
| salesChannel?: Enumeration, | ||
| parts?: Array<OrderPart>, | ||
| notes?: Array<{ |
There was a problem hiding this comment.
In current version, We decided to use communicationEvents for Notes.
Should we follow same pattern?
There was a problem hiding this comment.
Had a discussion with @dixitdeepak Sir on the pattern to be followed here, so concluded that we will be using commnicationEvents for storing the Notes and will be removing notes from the schema.
… deleted the identification schema(#2f2h74x)
…e usage of notes property(#2f2h74x)
