Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move userAgent substring generation from Bridge to Strada namespace #23

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Move userAgent substring generation from Bridge to Strada namespace #23

merged 1 commit into from
Aug 10, 2023

Conversation

jayohms
Copy link
Collaborator

@jayohms jayohms commented Aug 10, 2023

This PR moves user agent substring generation from Bridge to the top level Strada namespace.

Apps can obtain the user-agent string by calling:

Strada.userAgentSubstring(componentFactories)

It will produce a string that looks like:

"bridge-components: [one two three four]"

@jayohms jayohms requested a review from svara August 10, 2023 15:13
svara
svara approved these changes Aug 10, 2023
View reviewed changes
Copy link

@svara svara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jayohms jayohms merged commit 2fc64e8 into main Aug 10, 2023
1 check passed
@jayohms jayohms deleted the strada-useragent branch August 10, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svara svara svara approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayohms @svara