Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid accessing the bridge directly from within the BridgeComponent. #16

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Avoid accessing the bridge directly from within the BridgeComponent. #16

merged 1 commit into from
Aug 22, 2023

Conversation

svara
Copy link
Collaborator

@svara svara commented Aug 22, 2023

This PR adds reply(with:) function to BridgeDelegate to avoid accessing the bridge directly from within the BridgeComponent.

This is prerequisite work for enabling component message testing.

@svara
Add reply(with:) function to BridgeDelegate to avoid accessing the …
368f06b 
…bridge directly from within the BridgeComponent.
@svara svara requested a review from jayohms August 22, 2023 08:46
jayohms
jayohms approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@jayohms jayohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@svara svara merged commit b0414ba into main Aug 22, 2023
1 check passed
@svara svara deleted the bridge-access branch August 22, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayohms jayohms jayohms approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svara @jayohms