-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async javascript take 2 #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @joemasilotti!
I like that we offer both standard and async versions.
I've left some feedback in #30.
Async javascript take 2 feedback
This is ready for re-review @svara! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @joemasilotti!
I've noticed we were missing two non async reply(to...)
functions. I added them in #31.
By adopting async/await we've made some of the classes not thread safe. I'll fix this in an upcoming PR today.
Add missing non async reply functions
Nope, no relevant concerns on the Android side. Go ahead and merge 👍 |
@joemasilotti Let's wait with the merge. I've run into this issue https://forums.developer.apple.com/forums/thread/701553. I'll open a PR soon ~1h. |
…x a crash when using `evaluateJavaScript` function.
A second take on #26 where the two public functions
reply(to:)
andreply(with:)
are wrapped in aTask {}
block. This lets a developer use the async version or non-async version depending on their preference. For example:Notes