Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Strada integration to WebBottomSheetFragment in demo #321

Conversation

donnfelker
Copy link
Contributor

@donnfelker donnfelker commented Mar 19, 2024

This is being done for completeness' sake. I used the demo as a source of truth for my Strada integration, but I needed to add a button to the menu in a bottom sheet. This did not work and had me scratching my head, wondering why it was not working, yet Strada was wired up correctly. Then I realized that WebBottomSheetFragment did not extend WebFragment so all the BridgeDelegate stuff was not set up in the bottom sheet. This adds this setup to the WebBottomSheetFragment in the demo so that others do not run into this issue as I did.

Could we abstract this away so it's not duplicated? Yeah, but I'm calling YAGNI at this point as it's a demo.

@jayohms
Copy link
Collaborator

jayohms commented Mar 23, 2024

Thanks @donnfelker! This is a nice improvement for people that need this reference. Fyi, we have some work coming later this year that won't require this manual Strada setup... but until then, this is the way to do it.

@jayohms jayohms merged commit 2c76214 into hotwired:main Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants