Add Strada integration to WebBottomSheetFragment in demo #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being done for completeness' sake. I used the demo as a source of truth for my Strada integration, but I needed to add a button to the menu in a bottom sheet. This did not work and had me scratching my head, wondering why it was not working, yet Strada was wired up correctly. Then I realized that
WebBottomSheetFragment
did not extendWebFragment
so all theBridgeDelegate
stuff was not set up in the bottom sheet. This adds this setup to theWebBottomSheetFragment
in the demo so that others do not run into this issue as I did.Could we abstract this away so it's not duplicated? Yeah, but I'm calling YAGNI at this point as it's a demo.