Fernando/turbo navigator feedback #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naming is quite general. I'd prefer if we could change it to something omre specific.
| @@ -69,12 +69,15 @@ extension SceneController: UIWindowSceneDelegate { | |||
| extension SceneController: TurboNavigatorDelegate { | |||
| func handle(proposal: VisitProposal) -> ProposalResult { | |||
| switch proposal.viewController { | |||
| case "numbers": | |||
|
|
|||
There was a problem hiding this comment.
Is there a style guide we can follow for Swift code? I feel like we've gone back and forth removing/adding these blank lines a few times!
There was a problem hiding this comment.
😆
We don't use a style guide, but if you don't like the new lines, I'll adapt. I don't feel strongly about it.
There was a problem hiding this comment.
To be honest, I just run SwiftFormat on every file before I save it!
|
LGTM! Feel free to merge. |
joemasilotti
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Re-opened after I removed the Turbo enum issue.]
Three minor things. Feel free to cherry-pick any commits to your branch or merge if all commits are good!
Let me know what you think!