When replacing a root in a modal context, present a new modal flow #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no way to jump from one modal flow to another. The app has to manually dismiss the first modal flow, then request a new modal flow by creating a new visit proposal with a modal context. Here's my proposal: make
replace_root
consider the given context.default
, then behavior is unchanged: Dismiss if modal controller, then pop to root, then replace root controller on main stack.modal
then behavior is now: Dismiss if modal controller, then present a new modal.In my mind, this makes sense since replacing a modal root restarts the flow, but I'd like to get your thoughts before I move forward with tests.