Fix compatibility shim for mobile apps #372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue in the suggested compatibility shim for mobile apps, when the adapter is handled by turbolinks-ios or turbolinks-android. Because the reference to `adapter.visitStarted` is stored as a variable, when it's called again the reference to `this` is not pointing to the adapter's `this` but to `window`. Co-authored-by: Juan Zenón <juanzv@hey.com>
okcomputer93
commented
Aug 19, 2022
| @@ -135,7 +135,7 @@ window.Turbolinks = { | |||
|
|
|||
| // Old mobile adapters use visit.location.absoluteURL, which is not available | |||
| // because Turbo dropped the Location class in favor of the DOM URL API | |||
| const adapterVisitStarted = adapter.visitStarted | |||
| const adapterVisitStarted = adapter.visitStarted.bind(adapter) | |||
There was a problem hiding this comment.
We're having this issue while trying to migrate to Turbo from our apps in turbolinks-ios,when the visitStarted method in the adapter is called, this is a reference to window instead of the adapter itself:
https://github.com/turbolinks/turbolinks-ios/blob/1c891b9ffbb89666a05b7c5b02a8fdd700e92323/Turbolinks/WebView.js#L60-L63
|
cc @jayohms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the suggested compatibility shim for mobile apps,
when the adapter is handled by turbolinks-ios or turbolinks-android.
Because the reference to
adapter.visitStartedis stored as avariable, when it's called again the reference to
thisis not pointingto the adapter's
thisbut towindow.Co-authored-by: Juan Zenón juanzv@hey.com