Install cuprite
#422
Merged
Install cuprite
#422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
cuprite
branch
2 times, most recently
from
a303bc1 to
d7bd577
Compare
Execute System Tests through the CDP Protocol via [cuprite][]. This commit installs a dependency on [cuprite@~>0.9][] so that the `js_errors:` option is available. It was removed in subsequent releases, but its presence suits Turbo Rails well, since any JavaScript errors introduced by `turbo-rails.js` should fail the suite. [cuprite]: https://github.com/rubycdp/cuprite [cuprite@~>0.9]: https://github.com/rubycdp/cuprite/tree/v0.9#customization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute System Tests through the CDP Protocol via cuprite.
This commit installs a dependency on cuprite@~>0.9 so that the
js_errors:option is available. It was removed in subsequent releases, but its presence suits Turbo Rails well, since any JavaScript errors introduced byturbo-rails.jsshould fail the suite.