Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MiniTest -> Minitest #489

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Update MiniTest -> Minitest #489

merged 1 commit into from
Jul 27, 2023

Conversation

kevinmcconnell
Copy link
Contributor

Minitest recently dropped compatibility with the older Pascal-cased format of the module name. So to avoid failures on recent Minitest versions we should use the newer format.

@kevinmcconnell
Update MiniTest -> Minitest
9237699 
Minitest recently dropped compatibility with the older Pascal-cased
format of the module name. So to avoid failures on recent Minitest
versions we should use the newer format.
@kevinmcconnell kevinmcconnell requested a review from afcapel July 27, 2023 12:06
@kevinmcconnell
Copy link
Contributor Author

kevinmcconnell commented Jul 27, 2023 •
edited
Loading

This is to fix the recent CI failures on main.

(The original change is still failing against rails/main too, but that's a separate issue.)

afcapel
afcapel approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@afcapel afcapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kevinmcconnell kevinmcconnell merged commit d1dd296 into main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afcapel afcapel afcapel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinmcconnell @afcapel