Update Turbo Drive <meta> across navigations
#550
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seanpdoyle Thank you for looking into this. So I dig a bit more into it. does not work at all on first render. This is reasonable as the With layout: And different page: I'm getting doubled tags when navigating from root page to the given page. and this seems to work properly as the behavior are taken from last tags on the page. However when I enter the page directly (or refresh in the browser), I'm getting tags in such order: thus, it does not work as expected as the morphing is the last one. BTW, I'm using turbo-rails 2.0.0.pre.beta.2 (from gem) |
Closes [hotwired#549] Add System Test level coverage to ensure that Turbo Drive navigations will re-render any `<meta>` elements nested within the document's `<head>`. To achieve this coverage, introduce the `PagesController#show` action that links to HTML pages that render their `<head>` based on the `turbo_refresh_method` and `turbo_refresh_scroll` query parameters. [hotwired#549]: hotwired#549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #549
Add System Test level coverage to ensure that Turbo Drive navigations will re-render any
<meta>elements nested within the document's<head>.To achieve this coverage, introduce the
PagesController#showaction that links to HTML pages that render their<head>based on theturbo_refresh_methodandturbo_refresh_scrollquery parameters.