Make turbo_frame_request? a helper method
#564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my app, I was making an index view of records with an info frame at the top where you could edit the parent record. I thought that with broadcasting page refreshes everything would be updated even though in the controller it redirects to the same page (therefore normally only updating the frame), but because of the debouncing mechanism it didn't. I fixed the problem by forcing a full page reload if it came from a frame request, however, since only the
turbo_frame_request_idmethod is defined as a helper, I can't just useturbo_frame_request?and have to use the more awkwardturbo_frame_request_id.present?.