Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused morph tag builder #655

Merged
merged 1 commit into from
Aug 4, 2024
Merged

remove unused morph tag builder #655

merged 1 commit into from
Aug 4, 2024

Conversation

omarluq
Copy link
Contributor

@omarluq omarluq commented Aug 1, 2024 •
edited
Loading

left over code from initial morph implementation

seanpdoyle
seanpdoyle approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@seanpdoyle seanpdoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Are there test examples or any other mention?

@omarluq
Copy link
Contributor Author

omarluq commented Aug 1, 2024

Thank you! Are there test examples or any other mention?

NP, no other references to this 👍🏼

@dhh
Copy link
Member

dhh commented Aug 1, 2024

cc @jorgemanrubia

@AlexKovynev
Copy link
Contributor

AlexKovynev commented Aug 4, 2024 •
edited
Loading

anyway it is not enough need to fix this also #639
cause morph not usable now. Need to fix actions to not loose 'method'

@jorgemanrubia jorgemanrubia merged commit b0e7ebf into hotwired:main Aug 4, 2024
15 checks passed
@jorgemanrubia
Copy link
Member

Thanks @omarluq.

@AlexKovynev see my reply here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpdoyle seanpdoyle seanpdoyle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@omarluq @dhh @AlexKovynev @jorgemanrubia @seanpdoyle