Propose a replace visit on redirection (#328)

* Propose a `replace` visit instead of directly modifying the history and location

* Updated the browser adapter to remove the call to `followRedirect` as it now happens in the visit itself
* Updated the tests to reflect the new behaviour

* Added navigation tests for redirection

Co-authored-by: David Heinemeier Hansson <david@loudthinking.com>

src/core/drive/visit.ts

@@ -140,6 +140,7 @@ export class Visit implements FetchRequestDelegate {
       this.state = VisitState.completed
       this.adapter.visitCompleted(this)
       this.delegate.visitCompleted(this)
+      this.followRedirect()
     }
   }
 
@@ -259,8 +260,10 @@ export class Visit implements FetchRequestDelegate {
 
   followRedirect() {
     if (this.redirectedToLocation && !this.followedRedirect) {
-      this.location = this.redirectedToLocation
-      this.history.replace(this.redirectedToLocation, this.restorationIdentifier)
+      this.adapter.visitProposedToLocation(this.redirectedToLocation, {
+        action: 'replace',
+        response: this.response
+      })
       this.followedRedirect = true
     }
   }

src/core/native/browser_adapter.ts

@@ -56,7 +56,7 @@ export class BrowserAdapter implements Adapter {
   }
 
   visitCompleted(visit: Visit) {
-    visit.followRedirect()
+
   }
 
   pageInvalidated() {

src/tests/fixtures/navigation.html

@@ -33,6 +33,7 @@ <h1>Navigation</h1>
       <svg width="600" height="100" viewbox="-300 -50 600 100"><text><a id="cross-origin-link-inside-svg-element" href="about:blank">Cross-origin link inside SVG element</a></text></svg>
       <p><a id="link-to-disabled-frame" href="/src/tests/fixtures/frames/hello.html" data-turbo-frame="hello">Disabled turbo-frame</a></p>
       <p><a id="autofocus-link" href="/src/tests/fixtures/autofocus.html">autofocus.html link</a></p>
+      <p><a id="redirection-link" href="/__turbo/redirect?path=/src/tests/fixtures/one.html">Redirection link</a></p>
       <p><a id="headers-link" href="/__turbo/headers">Headers link</a></p>
     </section>
 

src/tests/functional/form_submission_tests.ts

@@ -44,7 +44,7 @@ export class FormSubmissionTests extends TurboDriveTestCase {
 
     this.assert.notOk(await this.formSubmitted)
     this.assert.equal(await this.pathname, "/src/tests/fixtures/one.html")
-    this.assert.equal(await this.visitAction, "advance")
+    this.assert.equal(await this.visitAction, "replace")
     this.assert.equal(await this.getSearchParam("greeting"), "Hello from a form")
   }
 

src/tests/functional/navigation_tests.ts

@@ -203,6 +203,21 @@ export class NavigationTests extends TurboDriveTestCase {
     this.assert.ok(await this.isScrolledToSelector("#main"), "scrolled to #main")
   }
 
+  async "test following a redirection"() {
+    await this.clickSelector('#redirection-link')
+    await this.nextBody
+    this.assert.equal(await this.pathname, "/src/tests/fixtures/one.html")
+    this.assert.equal(await this.visitAction, "replace")
+  }
+
+  async "test clicking the back button after redirection"() {
+    await this.clickSelector('#redirection-link')
+    await this.nextBody
+    await this.goBack()
+    this.assert.equal(await this.pathname, "/src/tests/fixtures/navigation.html")
+    this.assert.equal(await this.visitAction, "restore")
+  }
+
   async "test same-page anchor visits do not trigger visit events"() {
     const events = [
       "turbo:before-visit",