FetchRequest target could be any Element

hotwired · Aug 21, 2022 · 95590c4 · 95590c4
1 parent 59aa86f
commit 95590c4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/core/drive/visit.ts b/src/core/drive/visit.ts
@@ -51,7 +51,7 @@ export type VisitOptions = {
   shouldCacheSnapshot: boolean
   frame?: string
   acceptsStreamResponse: boolean
-  initiator?: HTMLAnchorElement | HTMLFormElement
+  initiator?: Element
 }
 
 const defaultOptions: VisitOptions = {
@@ -87,7 +87,7 @@ export class Visit implements FetchRequestDelegate {
   readonly willRender: boolean
   readonly updateHistory: boolean
   readonly promise: Promise<void>
-  readonly initiator?: HTMLAnchorElement | HTMLFormElement
+  readonly initiator?: Element
 
   private resolvingFunctions!: ResolvingFunctions<void>
 

diff --git a/src/core/session.ts b/src/core/session.ts
@@ -191,7 +191,7 @@ export class Session
     )
   }
 
-  followedLinkToLocation(link: HTMLAnchorElement, location: URL) {
+  followedLinkToLocation(link: Element, location: URL) {
     const action = this.getActionForLink(link)
     const acceptsStreamResponse = link.hasAttribute("data-turbo-stream")
 

diff --git a/src/http/fetch_request.ts b/src/http/fetch_request.ts
@@ -1,5 +1,4 @@
 import { FetchResponse } from "./fetch_response"
-import { FrameElement } from "../elements/frame_element"
 import { dispatch } from "../util"
 
 export type TurboBeforeFetchRequestEvent = CustomEvent<{
@@ -62,7 +61,7 @@ export class FetchRequest {
   readonly headers: FetchRequestHeaders
   readonly url: URL
   readonly body?: FetchRequestBody
-  readonly target?: FrameElement | HTMLFormElement | HTMLAnchorElement | null
+  readonly target?: Element | null
   readonly abortController = new AbortController()
   private resolveRequestPromise = (_value: any) => {}
 
@@ -71,7 +70,7 @@ export class FetchRequest {
     method: FetchMethod,
     location: URL,
     body: FetchRequestBody = new URLSearchParams(),
-    target: FrameElement | HTMLFormElement | HTMLAnchorElement | null = null
+    target: Element | null = null
   ) {
     this.delegate = delegate
     this.method = method