Support navigating a Frame to its current src
#383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
frame-navigate-same-src
branch
2 times, most recently
from
4e70875
to
d50359b
Compare
First, rename `hasBeenLoaded` to `willEagerLoad`, and flip the default from `false` to `true`. Next, set the flag to `false` if the `FrameController` is initialized with a `loading="lazy"` frame. Finally, set the flag to `true` once the element appears in the viewport for the first time.
Closes [hotwired#245][] Update the `FrameController.currentURL` from within `set sourceURL()` to ensure that `currentURL` does not still refer to the previous load's `sourceURL`. [hotwired#245]: hotwired#245
As an alternative to leaking internal `FrameController` state to the DOM as the `[reloadable]` attribute, this commit replaces those assignments and guard clause checks with references to `currentURL` instead. When responding to `<a>` clicks and `<form>` submissions, reset the `<turbo-frame>` element delegates `currentURL = null`. Adding a "public" (that is, package-internal) accessor to the `FrameElementDelegate` feels less committal than an end-user facing `[reloadable]` attribute, and achieves the same outcome.
seanpdoyle
force-pushed
the
frame-navigate-same-src
branch
from
d50359b
to
b6d27ff
Compare
|
Closing in favor of #487. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
hasBeenLoadedtowillEagerLoadFirst, rename
hasBeenLoadedtowillEagerLoad, and flip the defaultfrom
falsetotrue.Next, set the flag to
falseif theFrameControlleris initializedwith a
loading="lazy"frame. Finally, set the flag totrueonce theelement appears in the viewport for the first time.
Support navigating a Frame to its current
srcRe-opens #248
Closes #245
Update the
FrameController.currentURLfrom withinset sourceURL()toensure that
currentURLdoes not still refer to the previous load'ssourceURL.Replace
reloadableattribute withcurrentURLpropertyFollow-up to #263
As an alternative to leaking internal
FrameControllerstate to the DOMas the
[reloadable]attribute, this commit replaces those assignmentsand guard clause checks with references to
currentURLinstead.When responding to
<a>clicks and<form>submissions, reset the<turbo-frame>element delegatescurrentURL = null.Adding a "public" (that is, package-internal) accessor to the
FrameElementDelegatefeels less committal than an end-user facing[reloadable]attribute, and achieves the same outcome.