turbo:frame-missing: Do not Turbo.visit by default
#677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
frame-missing-event-visit
branch
3 times, most recently
from
9c52b1e to
520e10e
Compare
|
Curious why you want to roll this default behavior back, Sean? EDIT: Ah, I hadn't quite stumbled upon all the issues yet! For others, looks like Sean delved into this one in #670 (comment) and continued conversation is there |
seanpdoyle
force-pushed
the
frame-missing-event-visit
branch
from
520e10e to
53be1f7
Compare
Restore the existing default behavior when a matching frame is missing from a response: log an error and blank the frame. Alongside that original behavior, yield the [Response][] instance and a `Turbo.visit`-like callback that can transform the `Response` instance into a `Visit`. It also accepts all the arguments that the `Turbo.visit` call normally does. [Response]: https://developer.mozilla.org/en-US/docs/Web/API/Response
seanpdoyle
force-pushed
the
frame-missing-event-visit
branch
from
53be1f7 to
baef5af
Compare
|
I remain confident that the fallback to visit on missing frame is the better default. We allow you to catch the frame missing event, so you can always override that default if you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the existing default behavior when a matching frame is missing
from a response: log an error and blank the frame.
Alongside that original behavior, yield the Response instance and a
Turbo.visit-like callback that can transform theResponseinstanceinto a
Visit. It also accepts all the arguments that theTurbo.visitcall normally does.