Remove old React version and import React, ReactDOM and createReactCl… #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass directly from the entry-points In this commit (af4d9a8) React and ReactDOM where added as dependencies of the project But it seems that they are not used because no entry-point import them. The React version that is used is the version 0.12.2 that is coming from 2014 and it is loaded as a separate script directly from the HTML templates. The purpose of this commit is to import React, ReactDOM, and createReactClass from the entry-points and get rid of the old react version. In this way, the project can be escalated using the new features of React
elchininet
force-pushed
the
remove_old_react_version
branch
from
ce6e130
to
89266b7
Compare
hvariant
pushed a commit
to hvariant/hound
that referenced
this pull request
Oct 5, 2019
When hound search returns a large number of results it can be annoying to scroll through the everything to find what you need. This adds a button to collapse file body in search results. Note that this change depends on hound-search#324 which adds new version of React which has support for React.createRef.
This was referenced Nov 16, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old React version and import React, ReactDOM and createReactClass directly from the entry-points
In this commit (af4d9a8) React and ReactDOM where added as dependencies of the project
But it seems that they are not used because no entry-point import them. The React version that is used is the version 0.12.2 that is coming from 2014 and it is loaded as a separate asset.
The purpose of this commit is to import React, ReactDOM, and createReactClass from the entry-points and get rid of the old react version.
In this way, the project can be escalated using the new features of React