Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent line numbers from being copied in search results #468

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

ipagbox
Copy link
Contributor

@ipagbox ipagbox commented Jul 8, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

The PR fulfills these requirements:

  • All tests are passing?
  • New/updated tests are included?
  • If any static assets have been updated, has ui/bindata.go been regenerated?
  • Are there doc blocks for functions that I updated/created?

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
When I want to copy multiple lines of code from the search results, the line numbers are also copied.
image

So when I paste this into IDE or console, it may cause syntax errors.
image

The solution is to prevent line numbers from being copied in search results using CSS.
image

I hope this little trick is helpful.

P.S. As I noticed, now there is no need to regenerateui/bindata.go. So this line may be deleted from PR template. Right?

@ipagbox
Copy link
Contributor Author

ipagbox commented Jul 14, 2023

@salemhilal Could you check please?

Copy link
Contributor

@salemhilal salemhilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nudge @ipagbox. Lemme send this around to the rest of the team to see what they think, but this looks more than fine to me.

Copy link
Contributor

@jvt jvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@salemhilal salemhilal merged commit 4cbc3cf into hound-search:main Jul 14, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants