Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo test + clippy fix #16

Merged
merged 8 commits into from
Dec 30, 2021
Merged

cargo test + clippy fix #16

merged 8 commits into from
Dec 30, 2021

Conversation

yjshen
Copy link
Collaborator

@yjshen yjshen commented Dec 28, 2021 •
edited
Loading

decimal related ignored tests: 3

TODO:

@yjshen yjshen changed the title WIP fixing tests Pass all tests Dec 28, 2021
@yjshen yjshen changed the title Pass all tests cargo test + clippy fix Dec 28, 2021
@jorgecarleitao
Copy link

what is missing in the decimal? Let's raise it upstream so that we can keep parity - I believe decimal is supported in arrow2

@houqp
Copy link
Owner

houqp commented Dec 30, 2021

@jorgecarleitao just formatting bug that's easy to fix

@houqp houqp merged commit 752cb4b into houqp:arrow2_merge Dec 30, 2021
@yjshen yjshen mentioned this pull request Jan 17, 2022
Merged
@yjshen yjshen deleted the fix_test1 branch April 22, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
datafusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjshen @jorgecarleitao @houqp