Make ballista compile #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjshen
commented
Sep 24, 2021
| num_batches: u64, | ||
| num_rows: u64, | ||
| num_bytes: u64, | ||
| } | ||
|
|
||
| impl<'a> ShuffleWriter<'a> { | ||
| impl ShuffleWriter { |
There was a problem hiding this comment.
Please merge arrow2 master for the change of jorgecarleitao/arrow2@4c2f4dc
| .map(|pos| self.values()[pos].borrow()) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
As suggested by Jorge in jorgecarleitao/arrow2#416 (review)
| }) | ||
| .map_err(|e| from_ballista_err(&e))?; | ||
| let file_meta = read_file_metadata(&mut file).map_err(|e| from_arrow_err(&e))?; | ||
| let reader = FileReader::new(&mut file, file_meta, None); |
There was a problem hiding this comment.
Move file open as well as FileReader creation logic here for the lifetime requirements enforced by async move {...}
| @@ -109,7 +109,7 @@ impl CsvFile { | |||
|
|
|||
| /// Attempt to initialize a `CsvRead` from a reader impls `Seek`. The schema can be inferred automatically. | |||
| pub fn try_new_from_reader_infer_schema<R: Read + Seek + Send + Sync + 'static>( | |||
| mut reader: R, | |||
| reader: R, | |||
| // let a = Utf8Array::<i64>::from_slice(["abc"; 5]); | ||
| // let b = Utf8Array::<i64>::from_slice(["^a", "^A", "(b|d)", "(B|D)", "^(b|c)"]); | ||
| // let c = BooleanArray::from_slice(&[false, false, false, false, true]); | ||
| // test_coercion!(a, b, Operator::RegexNotIMatch, c); |
There was a problem hiding this comment.
commented out for binary.rs RegexIMatch not implemented
| ScalarValue::IntervalYearMonth(e) => match e { | ||
| Some(value) => dyn_to_array!(self, value, size, i32), | ||
| None => new_null_array(self.get_datatype(), size).into(), | ||
| }, |
There was a problem hiding this comment.
Remove duplicate patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?