-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get --old timezones into a usable and testable state #1
Conversation
Sorry for the ridiculously slow response. If you could redo this branch without checking in the generated files that'd be good. It's really hard to review as-is. |
Oops. Missed this one in my inbox. I'll try to do this sometime this week. |
Let me know if you want anything changed :) |
I don't really like the way you have the zone class files names. Having both Etc::GMT_4 and Etc::GMT__4 seems really confusing. Maybe call them Etc::GMT_M4 and Etc::GMT_P4, although the "minus" vs "plus" thing is totally backwards with these zones. I'd welcome a better suggestion, but I think distinguishing the two based on the number of underscores is not a great solution. Thanks, -dave |
Code has been updated with your suggestions, but instead of M/P let's be more explicit i.e:
|
Hey Dave, Have you been able to have a look again? Alfie |
I was crazy busy with http;//www.tcvegfest.com/ until quite recently. I'll try to take a look some time this month. |
All good :) Thanks for the update. |
I merged this manually. Note that I'm not going to enable --old by default so if you want these zones you'd have to rebuild the package from scratch. |
Hey Dave, Awesome. Thanks for doing that. |
Hey,
Timezones like 'Etc/GMT+5' end up creating modules like 'DateTime/TimeZone/Etc/GMT+5.pm'. The problem here is that they are not valid Perl module names, so they can't be use'd. These changes fixes this, creates correct offsets, and allows "parse_olson --old" to pass all tests again.