add some feature #154
Merged
add some feature #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2017 20:56
|
Thank you for the feature. Could you add some unit tests that verify these new functions? I would love to have the tests as part of the same PR. Thank you. |
|
@cpd0101 are you still interested in writing some tests for this feature? |
|
I've just forked @cpd0101 's repo; I'll try to make time to flesh out the unit tests (and perhaps some documentation) and submit a PR to supersede this one in due course. |
* Declare a new getter `_getChunks`, for testing purposes * Add javadoc for `_getBuffer` * Add a suite of tests that ensure that calls to `write` and `end` with payloads result in the correct state of `_data`, `_chunks` and `_buffer`. Ensure that methods are tested in isolation, using a separate suite for interactions between `write` and `end`
This was referenced Mar 4, 2018
|
PRs filed - 1 against @cpd0101's branch so that this can have tests, |
mockResponse - tests to verify `write()` and `end()` with payloads
|
LGTM, @howardabrams what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.