docs: Retire deprecated handler methods #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring the handler package deprecated some methods and this tutorial still uses those methods. Thus, this commit retires the following methods and use the new alternatives. * https://github.com/99designs/gqlgen/blob/5ad012e3d7be1127706b9c8a3da0378df3a98ec1/handler/handler.go#L17 * https://github.com/99designs/gqlgen/blob/5ad012e3d7be1127706b9c8a3da0378df3a98ec1/handler/handler.go#L242 See 99designs/gqlgen#885 for more details about the refactor.
To use out-of-box transport configurations, use handler.NewDefaultServer instead of handler.New.
|
Hi, thanks for the PR @takanabe! I noticed the same methods being called in content/backend/graphql-go/6-authentication.md (Line 272). Would you please take a look and consider updating that as well? I can approve the merge afterward. |
|
Merged. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Refactoring the handler package deprecated some methods and this tutorial still uses those methods. Thus, this commit retires the following methods and use the new alternatives.
See 99designs/gqlgen#885 for more details about the refactor.