-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: show battery voltage and power in live view #1131
improvement: show battery voltage and power in live view #1131
Conversation
Looks great to me. One thing to consider: This would be to much I think, but I guess (dis-)charge current is more important than power, is it? Edit: |
I think that we should not add too much data fields and choose wisely. But i dont have a clear opinion on current vs watts. EDIT: missed your edit. Two cards sound good. Whats your opinion @schlimmchen? |
MPPT Power: Watts. Inverter Power: Watts. Grid Power: Watts. Battery: Amps? Makes no sense to me.
Well... One card for three values does not look appealing to me. So, yeah. Two cards. I would say: "Battery Charge" (SoC and Voltage) and "Battery Power" (Watts and Amps). @AndreasBoehm Are you interested in trying to optimize the style? Instead of separating the two values of one card with a slash, you could put them in individual div tags and use CSS flex to make them use equal width. Actually, I just hacked it in the browser dev tools, it as easy as I had hoped: And just before the breakpoint where all cards take one row: What do you think of this? Unfortunately, the second card will get crowded, at least close to the breakpoint 🤷♂️ I don't care for the amps, to be honest... If you want them in, it's fine. I think they add no value in the header. |
well, I thought it is importantly as nearly every aspect of a battery is designed for a certain current. The wire size, fuse, also the discharge power is limited by discharge current, as the current increases with decreasing voltage, yet the power is stable. If your battery is well sized (not to say oversized for your load), you probably won’t gain anything with the information. But with smaller batteries, current rating gets more important. And, as I do electrical tests at work and also there everything is designed about current, not power, I’m just used to use amps :) another point, as battery’s used to have a Ah rating, it’s easier to get a rough feeling of how long you can still discharge a battery. OC only if you see the remaining Ah and the discharge current. 150Ah remaining and 10A current? So you have 15h left. More or less. and still: it’s just a point I wanted to mentioned and to discuss with you guys :) as I don’t have a battery yet. |
Exactly. As you know, I am also not a fan of the "battery discharge rate (current) regulation" issue.... |
I would also vote to for having the Ampere being displayed. |
offfopic: the most frustrating part? i can’t enjoy this as i’m on a 4MB board for quite foreseeable future :( |
a6a261d
to
49d62c1
Compare
not all battery providers know all values the base class manages. make sure to prevent publishing invalid values.
I did not know how much I needed this... It's awesome! I don't scroll any more to the bottom just to see the important battery stats when I am peeking the state of the system. Thanks, @AndreasBoehm ❤️ @spcqike I even enjoy the amperage, at least when it's high and I am rooting for the battery to fill up 😁 |
Nice to hear that its useful :) |
glad you like it after all :) next step could be an estimation, of how long you can (dis-)charge the battery. one could calculate a load1, load5 or load15 (or all), which represents the average current going in/out in the time period. if we know the Ah rating, which is given by some BMS, one could simply calculate OC this calculation is just be an aproximation (a calculation based on Wh would be more accurate, but also more complex) but i guess thats whats still done a lot when talking about battery capacity and "bridging time" (if thats the right english term :D) |
Der kriegt den Hals nicht voll 🙄 Mach ein Issue (feature request). |
na, so nun auch nicht :) war nur ne Idee, dass es ginge und evtl. auch interessant wäre in der Darstellung. Auch hier, da ich bisher gar keine Batterie habe 🤷♂️ habe ich von solchen Anpassungen so oder so nichts 😄 Im Zweifel würd ich sowas am Ende aber auch in Node-Red / Grafana einbauen. Ähnlich der "Restlaufzeit Anzeige" meiner USV. (die den Wert aber von sich aus ausgibt) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Resolves #1129
State of charge
toBattery Charge
Battery Power
card_current
from individual implementations toBatteryStats
_currentPrecision
_socPrecision
and_currentPrecision
everywhere