Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suites directory #782

Merged
merged 71 commits into from
Oct 4, 2024
Merged

Add suites directory #782

merged 71 commits into from
Oct 4, 2024

Conversation

hwikle-lanl
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl self-assigned this Aug 14, 2024
@hwikle-lanl hwikle-lanl linked an issue Aug 14, 2024 that may be closed by this pull request
Create 'suites' directory, test re-org #742
Closed
@Paul-Ferrell
Copy link
Collaborator

I'm pretty sure you're not actually ready for me to review this, but I see a few issues already.
The expected directory structure is:
suites/<suite_name>/
So for whatever suite you're looking at, you should be finding files under the specific directory for a suite rather than the general suites directory.

@hwikle-lanl hwikle-lanl force-pushed the 742-create-suites-directory-test-re-org branch from 5a50fa8 to 265fcfa Compare September 9, 2024 18:48
Paul-Ferrell
Paul-Ferrell reviewed Sep 21, 2024
View reviewed changes
lib/pavilion/filters/parse_time.py Outdated Show resolved Hide resolved
lib/pavilion/filters/parse_time.py Show resolved Hide resolved
lib/pavilion/commands/config.py Outdated Show resolved Hide resolved
lib/pavilion/builder.py Outdated Show resolved Hide resolved
lib/pavilion/series/test_set.py Outdated Show resolved Hide resolved
lib/pavilion/resolver/resolver.py Outdated Show resolved Hide resolved
@hwikle-lanl
Fix failing pylint tests in CI
7754b6e
@hwikle-lanl
Second try
bb7565d
@hwikle-lanl
Fix newly failing style tests
c76fc76
@hwikle-lanl
Update workflow file
92006ce
@hwikle-lanl
Try something else
c3c9ab3
@hwikle-lanl
Add suites directory
8d4feb2
@hwikle-lanl
Progress towards solution
0972b87
@hwikle-lanl
Further progress
29f42f7
@hwikle-lanl
Fix style issues
7a17eba
@hwikle-lanl
Increase timeout for test_owner
ec9c572 
Test had been passing on develop, but no longer is. Increasing
the timeout from 1 to 2 seconds causes it to pass. Something
has probable changed that is slowing the filesystem down.
@hwikle-lanl
Add suites tests
ce6e196
@hwikle-lanl
Fix mistake
d6a540a
@hwikle-lanl
Make resolver check both tests and suites dirs
efcb41e
@hwikle-lanl
Improve suites test
25f6b47
@hwikle-lanl
Pass basic suites test
ffc16b6
@hwikle-lanl
Fix regression
673b519
@hwikle-lanl
Add bare YAML suites test
15e198e
@hwikle-lanl
Stub out additional suites tests
99fd8e9
@hwikle-lanl
Refactor find_config
b2cce4d
@hwikle-lanl
Miscellaneous changes
b8fa001
@hwikle-lanl
Further progress
ca32ae2
@hwikle-lanl
Fix regression
f09c851
@hwikle-lanl
Progress towards proper parsing of host config
38aa538
@hwikle-lanl
Progress towards solution
a752ace
@hwikle-lanl
Implement true directory hashing
0c26d17
@hwikle-lanl
Improve directory hashing algorithm
6d999c0
@hwikle-lanl
Add missing import
a2047b8
@hwikle-lanl
Ignore yaml config files when hashing directories
4d2bc83
@hwikle-lanl
Fix style issues
2144497
@hwikle-lanl
Remove stray pdb statement
4670b7d
@hwikle-lanl
Pull parsetime bugfix over from other branch
41adf46
@hwikle-lanl
Pass hashing unit test
ec87952
@hwikle-lanl
Remove unused test data
5b27964
@hwikle-lanl
Refactor find_file
1962e7c
@hwikle-lanl
Increase timeout for series cmd tests
a83ac9e
@hwikle-lanl
Fix bug in find_file
f8e2e12
@hwikle-lanl
Fix suite path (hopefully)
90693a9
@hwikle-lanl
Fix source path issue (finger crossed)
c25ed77
@hwikle-lanl
Fix download destination
570ec4e
@hwikle-lanl
Add docstring for safe_update
8edc490
@hwikle-lanl
Miscellaneous changes
ada1aee
@hwikle-lanl
Pass suite_with_source test
5b4d6d4
@hwikle-lanl
Fix regressions
6ad35b9
@hwikle-lanl
Pass suite_with_source unittest
d39693c
@hwikle-lanl
Pass circular_symlink unittest
084c151
@hwikle-lanl
Finish implementing PR feedback
793f911
@hwikle-lanl hwikle-lanl force-pushed the 742-create-suites-directory-test-re-org branch from 461cceb to 793f911 Compare September 27, 2024 21:00
@hwikle-lanl hwikle-lanl marked this pull request as ready for review October 4, 2024 14:12
@hwikle-lanl hwikle-lanl merged commit 1ccee5c into develop Oct 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Ferrell Paul-Ferrell Awaiting requested review from Paul-Ferrell

Assignees

@hwikle-lanl hwikle-lanl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create 'suites' directory, test re-org
2 participants
@hwikle-lanl @Paul-Ferrell