Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31003 Move instead of copying objects to improve performance #19371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HPCC-31003 Move instead of copying objects to improve performance #19371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/workunit/workunit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2708,7 +2708,7 @@ void StatisticsAggregator::recordStats(IStatisticCollection * sourceStats, unsig
verifyex(graphScopeId.setScopeText(graphName));
StatsScopeId wfScopeId(SSTworkflow, wfid);
StatsScopeId sgScopeId(SSTsubgraph, sgId);
statsCollection->recordStats(mapping, sourceStats, {wfScopeId, graphScopeId, sgScopeId});
statsCollection->recordStats(mapping, sourceStats, {std::move(wfScopeId), std::move(graphScopeId), std::move(sgScopeId)});
}

// Recalculate aggregates and then write the aggregates to global stats (dali)
Expand Down
2 changes: 1 addition & 1 deletion system/jlib/jstats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2242,7 +2242,7 @@ class CStatisticCollection : public CInterfaceOf<IStatisticCollection>
++scopeItem;
}

CStatisticCollection * tgtScopeCollection = ensureSubScopePath(path);
CStatisticCollection * tgtScopeCollection = ensureSubScopePath(std::move(path));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More efficient is to change the prototype of ensureSubScopePath:

CStatisticCollection * ensureSubScopePath(const std::initializer_list<const StatsScopeId> & path)

Copy link
Contributor Author

@shamser shamser Dec 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would. But the suggested change it would no longer be possible to provide an initializer list to ensureSubScopePath. For example, this would no longer be possible ensureSubScopePath({scope1, scope2, scope3}). Do you think we should still go with changing the arg to a reference? @ghalliday

bool wasUpdated = false;
// More efficient to iterate over stats rather than mapping...
ForEachItemIn(i, curSrcCollection->stats)
Expand Down
Loading