Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-33150 Avoid padding logical files with empty parts #19374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HPCC-33150 Avoid padding logical files with empty parts #19374

wants to merge 1 commit into from

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Dec 23, 2024 •
edited
Loading

When targeting a cluster/plane that was wider than the Thor instance, Thor used to ensure the target file width matched the width of the target cluster (or plane), by in part, creating empty physical files.
This behaviour becomes more common in a containerized world, where the target plane is normally the default data plane with a width that doesn't relate to a Thor instance.

Turn off this behaviour by default, allow it to be re-enabled in configuration or on a per output basis as a fail-safe.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jakesmith
HPCC-33150 Avoid padding logical files with empty parts
0eddb1e 
When targeting a cluster/plane that was wider than the Thor
instance, Thor used to ensure the target file width matched the
width of the target cluster (or plane), by in part, creating
empty physical files.
This behaviour becomes more common in a containerized world,
where the target plane is normally the default data plane with
a width that doesn't relate to a Thor instance.

Turn off this behaviour by default, allow it to be re-enabled
in configuration or on a per output basis as a fail-safe.

Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33150

Jirabot Action Result:
Assigning user: jake.smith@lexisnexisrisk.com
Workflow Transition To: Merge Pending
Updated PR

@jakesmith jakesmith requested a review from ghalliday December 23, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday Awaiting requested review from ghalliday

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakesmith